removed duplication of mdp_json_path in compilation command (#706)#779
Open
removed duplication of mdp_json_path in compilation command (#706)#779
mdp_json_path in compilation command (#706)#779Conversation
Needed for passing custom config via vllm. --------- Signed-off-by: Onkar Chougule <ochougul@qti.qualcomm.com> Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com> Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
ochougul
requested review from
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-rishinr
requested changes
Feb 13, 2026
| ) | ||
|
|
||
| if prefill_only is None or not prefill_only: | ||
| if (prefill_only is None or not prefill_only) and prefill_seq_len != 1: |
Contributor
There was a problem hiding this comment.
Can we set the prefill_only to false as default value?
| if decode_spec: | ||
| specializations.append(decode_spec) | ||
|
|
||
| if kw_spec := compiler_options.pop("specializations", None): |
Contributor
There was a problem hiding this comment.
nit: This can be simplified to
if "specializations" in compiler_options:
specializations = compiler_options.pop("specializations")
| from QEfficient.transformers.quantizers import replace_transformers_quantizers, undo_transformers_quantizers | ||
|
|
||
| model_id = "openai/gpt-oss-120b" # weights are not required to convert to fp32 | ||
| model_id = "openai/gpt-oss-20b" # weights are not required to convert to fp32 |
Contributor
There was a problem hiding this comment.
Use dummy config instead of full model
| from QEfficient.transformers.quantizers import replace_transformers_quantizers, undo_transformers_quantizers | ||
|
|
||
| model_id = "openai/gpt-oss-120b" # weights are not required to convert to fp32 | ||
| model_id = "openai/gpt-oss-20b" # weights are not required to convert to fp32 |
Contributor
There was a problem hiding this comment.
Use dummy config instead of full model
| def test_disagg_mode_prefill_only_and_decode_only(model_id, prompt): | ||
| # Run prefill for original pytorch model | ||
| tokenizer = AutoTokenizer.from_pretrained(model_id) | ||
| PREFILL_SEQ_LEN = 256 |
Contributor
There was a problem hiding this comment.
you can define the constants in the dummy config. tests/transformers/models/custom_tiny_model_configs.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for passing custom config via vllm.